Skip to content

docs: added migration guide for ButtonBase#1054

Merged
georgewrmarshall merged 2 commits intomainfrom
docs/button-base-migration
Apr 9, 2026
Merged

docs: added migration guide for ButtonBase#1054
georgewrmarshall merged 2 commits intomainfrom
docs/button-base-migration

Conversation

@kirillzyusko
Copy link
Copy Markdown
Collaborator

@kirillzyusko kirillzyusko commented Apr 8, 2026

Description

Added migration guide for ButtonBase.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/DSYS-637

Manual testing steps

  1. Open Readme
  2. Check migration instructions

Screenshots/Recordings

Before

N/A

After

image

Pre-merge author checklist

  • I've followed MetaMask Contributor Docs
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: documentation-only changes that don’t affect runtime code paths.

Overview
Adds a new ButtonBase migration section to MIGRATION.md, including import/prop mappings (e.g., labelchildren, widthisFullWidth, loadingisLoading, ButtonSizeButtonBaseSize) and before/after examples.

Updates the ButtonBase component README to link to this new migration guide for legacy MetaMask Mobile consumers.

Reviewed by Cursor Bugbot for commit cde80b6. Bugbot is set up for automated code reviews on this repo. Configure here.

@kirillzyusko kirillzyusko self-assigned this Apr 8, 2026
@kirillzyusko kirillzyusko added the documentation Improvements or additions to documentation label Apr 8, 2026
@kirillzyusko kirillzyusko changed the title docs: added migration guide docs: added migration guide for ButtonBase Apr 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

📖 Storybook Preview

@kirillzyusko kirillzyusko marked this pull request as ready for review April 9, 2026 14:46
@kirillzyusko kirillzyusko requested a review from a team as a code owner April 9, 2026 14:46
Copy link
Copy Markdown
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@georgewrmarshall georgewrmarshall enabled auto-merge (squash) April 9, 2026 19:36
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

📖 Storybook Preview

@georgewrmarshall georgewrmarshall merged commit 01a6890 into main Apr 9, 2026
44 checks passed
@georgewrmarshall georgewrmarshall deleted the docs/button-base-migration branch April 9, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants